Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make what the packer is doing more observable and we can see if there's heavy backlog
Note
Low Risk
Low risk observability change: adds new Prometheus gauges and a small trainer-side hook to report packer buffer sizes/round-robin state, with no impact to training logic beyond metrics emission.
Overview
Improves multi-run packer observability by exporting per-run buffer backlog and the packer’s round-robin position as Prometheus metrics.
MultiPackernow exposesget_buffer_stats(), the training loop conditionally reports these stats toMetricsServer, andmetrics_server.pyadds/cleans up the newtrainer_packer_buffer_length{run=...}andtrainer_packer_round_robin_positiongauges.Written by Cursor Bugbot for commit 9701bfe. This will update automatically on new commits. Configure here.